🔨 refactor suggested chart revision tool to use knex

[danyx23]

This PR refactors the last TypeORM class which is the suggested chart revision tool and entity. This one is a bit bigger of a change because the old code was mutating objects quite a bit and this refactor changes the code to work in a more predictable way of making new objects when going from unparsed to parsed (raw to enriched) db objects.

[danyx23]

• 🔨 refactor suggested chart revision tool to use knex #3396 👈
• Fix remaining refactor issues #3391
• 🔨 images need a RW transaction in case they need to update the db 😢 - bubble this up #3385
• ✨ unify transaction creation and close db connection in same call for scripts #3360
• 🔨 switch almost all remaining typeorm util function holdouts to knex #3359
• 🔨 set up eslint rule to error on dangling promises + fix 245 violations #3358
• 🚧 remove typeorm annotations from GDocs classes #3299 : 1 other dependent PR (#3372 )
• 🐝 remove obsolete code #3298
• 🔨 migrate charts from typeorm to knex #3293
• 🔨 clean up posts access via knex #3292
• ✨ add transaction types and api route helpers #3271
• 🔨 migrate PostLink to knex #3259
• 💄 reorder parameters of knexRaw and knexRawFirst to have knex in first pos #3258
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite

[lucasrodes]

Hi @danyx23, thanks for doing this refactor!

I tested it, and it works as expected (even the bug is preserved).

LGTM

[danyx23]

Very good to know that the bug is preserved 😜 . Thanks for testing it! 🙏

[danyx23]

Merge activity

• Mar 26, 10:04 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
• Mar 26, 10:31 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 26, 10:34 AM EDT: @danyx23 merged this pull request with Graphite.