🎉 add allGraphersLoaded Event
#3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
danyx23
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes #3087 further by adding an event that will dispatch on any page to confirm that all graphers have loaded.
This is necessary for this site-screenshots PR so that we can reliably take a screenshot once the page is ready instead of sleeping an arbitrary amount of time that will either be too long or too short for most pages.
I can imagine we'll forget this code exists and accidentally break it from time to time, but once we have a proper site screenshots test on every page type, we'll be able to make our CI tests fail until it's resolved (or confidently vetoed, like we do with the SVG tester)