Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 lightning chart deploys #3031

Closed
wants to merge 1 commit into from
Closed

Conversation

Marigold
Copy link
Contributor

@Marigold Marigold commented Dec 18, 2023

Problem

Updating a chart enqueues a full deploy that can take >15min and is prone to errors (due to high load on external servers like R2 or Spaces). Deploying only a single chart could significantly speed up most deploys.

Solution

  • Add the bakeCharts command that is very similar to bakeGDocs, which takes care of GDocs lightning deploys
  • Trigger a deployment after clicking on Update chart or Publish buttons
  • Lightning build with chartSlug goes to deploy queue which triggers BuildkiteJob OWID - deploy content with env variable LIGHTNING_CHART_SLUGS
  • Buildkite runs bakeCharts --slugs LIGHTNING_CHART_SLUGS on the server, syncs grapher/exports with generated png & svg to R2 and then deploys the site to Cloudflare

Potential issues

What other things need to happen when we publish or update a chart? Perhaps updated redirects might require full rebuild or at least rebuilding of redirects file in Buildkite.

Things that could be affected by updated chart (need to check)

  • explorer based indicators
  • prominent links

@Marigold Marigold force-pushed the lightning-chart-deploys branch from 3376a10 to a065383 Compare December 18, 2023 12:58
Copy link

github-actions bot commented Jan 3, 2024

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Jan 3, 2024
@Marigold
Copy link
Contributor Author

Marigold commented Jan 3, 2024

Longer discussion on slack. It's not clear whether this is worth merging. We should ask authors if they're even interested in this.

@github-actions github-actions bot removed the stale label Jan 4, 2024
@ikesau
Copy link
Member

ikesau commented Jan 16, 2024

From Gdocs, prominent links to gdocs are already broken which means they're probably not used anywhere.

There are still WP articles that use (working) prominent links for graphers though 😢

@danyx23
Copy link
Contributor

danyx23 commented Jan 16, 2024

@Marigold we'll try to do a product hour about gdocs at some point soon and then ask authors how much this is bothering them. Suggest we keep this open until then.

@Marigold
Copy link
Contributor Author

@danyx23 good. I was gonna ask, but thought I'd wait for Matthieu's build notifications first. Maybe these are the answer rather than faster builds.

Copy link

github-actions bot commented Feb 1, 2024

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Feb 1, 2024
@github-actions github-actions bot closed this Feb 4, 2024
@Marigold
Copy link
Contributor Author

Marigold commented Feb 6, 2024

It turned out authors don't really need this. It could still be useful for approving charts that trigger chart updates and it could eliminate freezing of admin, but it's probably not worth at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants