Simplify authors fields in posts table, introduce better DB interaction for Posts #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
4
to
6
| const formattingOptionsMatch = html.match( | ||
| /<!--\s*formatting-options\s+(.*)\s*-->/ | ||
| ) |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
danyx23
changed the base branch from
master
to
wp-sync-align-with-post-update-hook
danyx23
force-pushed
the
wp-sync-align-with-post-update-hook
branch
from
9d5fbf7 to
33da95c
Compare
danyx23
force-pushed
the
simplify-post-authors-cleanup-post-type
branch
from
3717429 to
99a1840
Compare
This was referenced Dec 15, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
danyx23
force-pushed
the
wp-sync-align-with-post-update-hook
branch
from
33da95c to
9b6a951
Compare
danyx23
force-pushed
the
simplify-post-authors-cleanup-post-type
branch
from
99a1840 to
91944d7
Compare
danyx23
force-pushed
the
wp-sync-align-with-post-update-hook
branch
from
9b6a951 to
96fe052
Compare
danyx23
force-pushed
the
simplify-post-authors-cleanup-post-type
branch
from
54e62fd to
b1f8ed0
Compare
Base automatically changed from
wp-sync-align-with-post-update-hook
to
master
December 21, 2023 17:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
authorsfield in thepoststable to contain simply an ordered list of authors (instead of an unordered list of json objects with{author: string, order: number}type)PostRowtype that represents a result for of the posts table into two, onePostRowRawwhere authors and formattingOptions are still string fields and onePostRowEnrichedwhere the json fields are parsed and the typed accordingly.