Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use <CodeSnippet> in embed modal #2897

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

marcelgerber
Copy link
Member

Just getting rid of some code that used to be duplicated.

They look a bit different, but not by all that much. Left is what's currently live, right is the new one:
CleanShot 2023-11-06 at 13 37 58

@sophiamersmann
Copy link
Member

Good call to get rid of duplicate code now that we have shared components!

I think it would be good though to use the appropriate colour scheme when used in Grapher. This is how I've done it as part of our data page / sources tab effort: https://github.com/owid/owid-grapher/blob/data-page-about-this-data/packages/%40ourworldindata/components/src/CodeSnippet/code-snippet.scss

I think it might make sense to wait with this PR until those changes are merged?

@marcelgerber
Copy link
Member Author

I think it might make sense to wait with this PR until those changes are merged?

ah, right, makes sense of course! :)

@larsyencken
Copy link
Contributor

larsyencken commented Nov 21, 2023

@sophiamersmann Assigning this one to you to update/merge when you think it's ready, since Marcel's off now.

If that looks like a lot of work, you can close this PR for now without merging.

@sophiamersmann sophiamersmann removed their request for review November 23, 2023 09:36
@sophiamersmann sophiamersmann merged commit d915004 into master Nov 28, 2023
13 checks passed
@sophiamersmann sophiamersmann deleted the embed-code-snippet branch November 28, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants