Fix thumbnails for prominent link to Graphers / Explorers #2893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea at a fix for #2870
I really can't see how prominent links were working with plain Grapher URLs before, except I know they were. Something must have been removed at some point. 😓
Anyway, this adds a little fork at the Prominent Link level, to load via the Grapher preview worker instead of via the Image attachments system. It doesn't currently take the query string into account, that but seems like an improvement over it breaking.
Example Archie
Results
@marcelgerber do you think this is an okay way to do this? In my mind this is the same sort of dependency as
DATA_API_URL
, but maybe there are reasons we don't want to add this?If we go with this we also might want to look at how
BAKED_GRAPHER_EXPORTS_BASE_URL
is formed