New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(explorer): enable warning for mixed-content explorers #2765

Merged

sophiamersmann merged 1 commit into master from show-warning-in-mixed-content-explorers

Oct 13, 2023

Member

sophiamersmann commented Oct 13, 2023 •

edited

Loading

resolves Add a warning to the explorer admin when an explorer is mixed-content #2504

I had disabled the warning for mixed content explorers as a hot fix for hot fix(explorer): prevent HotTable context menu from disappearing #2598
Referencing program.whyIsExplorerProgramInvalid lead to the component being re-rendered every few seconds (probably some mobx issue...)
Wrapping whyIsExplorerProgramInvalid in a computed property fixes the issue


          chore(explorer): enable warning for mixed-content explorers

a34378d

github-actions bot assigned sophiamersmann

sophiamersmann merged commit 3842687 into master

17 checks passed

sophiamersmann deleted the show-warning-in-mixed-content-explorers branch

October 13, 2023 14:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet