chore: update node version in dockerfiles & tests

owid · Jan 7, 2025 · fa3bde8 · fa3bde8
1 parent f45a4e9
commit fa3bde8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -1,4 +1,4 @@
-ARG VARIANT=18
+ARG VARIANT=22
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:dev-${VARIANT}
 
 COPY .tmux.conf /home/node/.tmux.conf

diff --git a/adminSiteServer/app.test.ts b/adminSiteServer/app.test.ts
@@ -213,7 +213,7 @@ describe("OwidAdminApp", () => {
         )
         expect(nodeVersion.status).toBe(200)
         const text = await nodeVersion.text()
-        expect(text).toBe("v18.16.0")
+        expect(text).toBe("v22.12.0")
     })
 
     it("should be able to edit a chart via the api", async () => {

diff --git a/docker-compose.devcontainer.yml b/docker-compose.devcontainer.yml
@@ -20,7 +20,7 @@ services:
             dockerfile: Dockerfile
             args:
                 # [Choice] Node.js version: 16, 14, 12
-                VARIANT: 18
+                VARIANT: 22
                 # On Linux, you may need to update USER_UID and USER_GID below if not your local UID is not 1000.
                 #USER_UID: 1000
                 #USER_GID: 1000

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
     "private": true,
     "version": "3.0.0",
     "engines": {
-        "node": ">=18.16"
+        "node": ">=22.0"
     },
     "packageManager": "[email protected]",
     "scripts": {