Remove unused env vars (#4360)

✨ This improves the parity with admin-env.secret, so setting up a new dev environment requires less guesswork. Removed unused env vars from server settings: - GDOCS_IMAGES_BACKPORTING_TARGET_FOLDER - GDOCS_SHARED_DRIVE_ID Move GDOCS_DONATE_FAQS_DOCUMENT_ID to admin-env.secret (see owid/ops#252)
owid · Jan 10, 2025 · f2c69b4 · f2c69b4
1 parent 98092b8
commit f2c69b4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/.env.devcontainer b/.env.devcontainer
@@ -14,7 +14,6 @@ GDOCS_PRIVATE_KEY=''
 GDOCS_CLIENT_EMAIL=''
 GDOCS_CLIENT_ID=''
 GDOCS_BASIC_ARTICLE_TEMPLATE_URL=''
-GDOCS_SHARED_DRIVE_ID=''
 
 R2_ENDPOINT=''
 IMAGE_HOSTING_R2_CDN_URL=''

diff --git a/.env.example-full b/.env.example-full
@@ -19,8 +19,9 @@ GDOCS_PRIVATE_KEY=
 GDOCS_CLIENT_EMAIL=
 GDOCS_CLIENT_ID=
 GDOCS_BASIC_ARTICLE_TEMPLATE_URL=
-GDOCS_SHARED_DRIVE_ID=
-GDOCS_DONATE_FAQS_DOCUMENT_ID=  # optional
+GDOCS_DETAILS_ON_DEMAND_ID=
+GDOCS_DONATE_FAQS_DOCUMENT_ID=
+GDOCS_BACKPORTING_TARGET_FOLDER=  # optional
 
 R2_ENDPOINT=  # optional
 IMAGE_HOSTING_R2_CDN_URL=

diff --git a/settings/serverSettings.ts b/settings/serverSettings.ts
@@ -123,14 +123,8 @@ export const GDOCS_CLIENT_ID: string = serverSettings.GDOCS_CLIENT_ID ?? ""
 export const GDOCS_BACKPORTING_TARGET_FOLDER: string =
     serverSettings.GDOCS_BACKPORTING_TARGET_FOLDER ?? ""
 
-export const GDOCS_IMAGES_BACKPORTING_TARGET_FOLDER: string =
-    serverSettings.GDOCS_IMAGES_BACKPORTING_TARGET_FOLDER ?? ""
-
 export const GDOCS_DONATE_FAQS_DOCUMENT_ID: string =
-    serverSettings.GDOCS_DONATE_FAQS_DOCUMENT_ID ??
-    "194PNSFjgSlt9Zm5xYuDOF0l_GLKZbVxH2co3zCok_cE"
-
-export const GDOCS_SHARED_DRIVE_ID = serverSettings.GDOCS_SHARED_DRIVE_ID ?? ""
+    serverSettings.GDOCS_DONATE_FAQS_DOCUMENT_ID ?? ""
 
 export const GDOCS_DETAILS_ON_DEMAND_ID =
     serverSettings.GDOCS_DETAILS_ON_DEMAND_ID ?? ""