Skip to content

Commit

Permalink
chore: update to Node 22 (#4351)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelgerber authored Jan 14, 2025
1 parent 5537ae3 commit 53e97fe
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG VARIANT=18
ARG VARIANT=22
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:dev-${VARIANT}

COPY .tmux.conf /home/node/.tmux.conf
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.16.0
22.13.0
2 changes: 1 addition & 1 deletion adminSiteServer/app.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ describe("OwidAdminApp", () => {
)
expect(nodeVersion.status).toBe(200)
const text = await nodeVersion.text()
expect(text).toBe("v18.16.0")
expect(text).toBe("v22.13.0")
})

it("should be able to edit a chart via the api", async () => {
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.devcontainer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ services:
dockerfile: Dockerfile
args:
# [Choice] Node.js version: 16, 14, 12
VARIANT: 18
VARIANT: 22
# On Linux, you may need to update USER_UID and USER_GID below if not your local UID is not 1000.
#USER_UID: 1000
#USER_GID: 1000
Expand Down
2 changes: 1 addition & 1 deletion docs/local-typescript-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This local environment requires some manual setup. For a faster way to get start

You need the following to be able to compile the grapher project and run the tests or use our Storybook:

- [Node 18](https://nodejs.org/en/)
- [Node 22](https://nodejs.org/en/)
- [Yarn](https://yarnpkg.com/)

All further dependencies will be automatically installed by the yarn package manager.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": true,
"version": "3.0.0",
"engines": {
"node": ">=18.16"
"node": ">=22.0"
},
"packageManager": "[email protected]",
"scripts": {
Expand Down

0 comments on commit 53e97fe

Please sign in to comment.