Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-office): correcting design for delete modal users #15085

Merged
merged 1 commit into from
Jan 23, 2025
Merged

feat(web-office): correcting design for delete modal users #15085

merged 1 commit into from
Jan 23, 2025

Conversation

stif59100
Copy link
Contributor

@stif59100 stif59100 commented Jan 23, 2025 •
edited
Loading

Question Answer
Branch? `feat/office365-react-app
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16817
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

I changed delete modal design

Related

@stif59100 stif59100 requested review from anooparveti, ghyenne, seven-amid and aottr and removed request for a team January 23, 2025 15:17
@github-actions github-actions bot added build Changes that affect the build system or external dependencie continuous-integration Changes to our CI configuration files and scripts universe-web-cloud universe-bare-metal-cloud universe-telecom translation required dependencies Pull requests that update a dependency file universe-public-cloud container enabler common feature New feature labels Jan 23, 2025
@stif59100 stif59100 force-pushed the feat/office365-react-app branch from f48706a to 9af141d Compare January 23, 2025 15:19
@stif59100 stif59100 changed the title Feat/manager 16817 feat(web-office): correcting design for delete modal users Jan 23, 2025
@github-actions github-actions bot removed the build Changes that affect the build system or external dependencie label Jan 23, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stif59100 stif59100 merged commit ae1e93f into feat/office365-react-app Jan 23, 2025
12 of 14 checks passed
@stif59100 stif59100 deleted the feat/MANAGER-16817 branch January 23, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyenne ghyenne ghyenne approved these changes

@tristanwagner tristanwagner tristanwagner approved these changes

@fredericvilcot fredericvilcot Awaiting requested review from fredericvilcot

@frenautvh frenautvh Awaiting requested review from frenautvh

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@aottr aottr Awaiting requested review from aottr aottr was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stif59100 @tristanwagner @ghyenne