feat(pci.savings-plan): improve dashboard ui #15043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-ciccotti
requested review from
anooparveti,
darsene,
frenautvh,
seven-amid and
aottr
and removed request for
a team
github-actions
bot
added
translation required
dependencies
Eric-ciccotti
force-pushed
the
feat/TAPC-2358-skeleton-structure
branch
from
fec8913 to
5a0ea22
Compare
packages/manager/apps/pci-savings-plan/src/components/Dashboard/Filters/Filters.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-savings-plan/src/components/Dashboard/Filters/Filters.tsx
Outdated
Show resolved
Hide resolved
Eric-ciccotti
force-pushed
the
feat/TAPC-2358-skeleton-structure
branch
3 times, most recently
from
ad0fae3 to
fcfc32c
Compare
packages/manager/apps/pci-savings-plan/public/translations/dashboard/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-savings-plan/src/components/Dashboard/Filters/Filters.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-savings-plan/src/components/Dashboard/Filters/Filters.tsx
Outdated
Show resolved
Hide resolved
Eric-ciccotti
force-pushed
the
feat/TAPC-2358-skeleton-structure
branch
from
fcfc32c to
f443694
Compare
Tsiorifamonjena
approved these changes
Jan 23, 2025
ppprevost
reviewed
Jan 23, 2025
packages/manager/apps/pci-savings-plan/src/components/Dashboard/Kpis/Kpis.tsx
Show resolved
Hide resolved
SimonChaumet
approved these changes
Jan 23, 2025
| className="my-auto" | ||
| aria-labelledby="tooltip-default" | ||
| name="circle-question" | ||
| id={`trigger-${index}`} |
There was a problem hiding this comment.
since the title is used as a key in above component, could it be used here also to replace the index ?
There was a problem hiding this comment.
That doesn't work (the tooltip component), I tried this out first.
There was a problem hiding this comment.
Yes, I checked the ID for 'odstooltips', and it seems to require a string that must follow these rules: no white spaces, no special characters, and no uppercase letters.
ref: TAPC-2358 Signed-off-by: Eric Ciccotti <[email protected]>
Eric-ciccotti
force-pushed
the
feat/TAPC-2358-skeleton-structure
branch
from
f443694 to
cdbb093
Compare
|
lionel95200x
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/TAPC-2358-svp-dashboardDescription
Improve dashboard UI on savings plan