Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container): project listing searchbox in legacy sidebar #14868

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(container): project listing searchbox in legacy sidebar #14868

wants to merge 1 commit into from
+14 −10

Conversation

aottr
Copy link

@aottr aottr commented Jan 10, 2025

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix PRB0041877
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • Fixed button visibility and misalignment (a pseudo button was visible above the input field, causing a misalignment of icons inside)
  • Fixed search not accepting uppercase words in search
    ref: PRB0041877

Related

@aottr
fix(container): project listing searchbox in legacy sidebar
a16708a 
- Fixed button visibility and misalignment
- Fixed search not accepting caps in search
ref: PRB0041877

Signed-off-by: Dustin Kroger <[email protected]>
@aottr aottr requested review from a team as code owners January 10, 2025 14:39
@github-actions github-actions bot added container bug Something isn't working labels Jan 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SimonChaumet
SimonChaumet reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@SimonChaumet SimonChaumet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit naming format isn't respected, it should an infinite verb instead of "project"

.../container/src/container/legacy/server-sidebar/universe/public-cloud/pci-sidebar.module.scss
@@ -171,6 +171,10 @@
top: 0.375rem;
right: 0.625rem;
}
button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be more specific ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonChaumet SimonChaumet SimonChaumet left review comments

@mhelhali-soufien mhelhali-soufien mhelhali-soufien approved these changes

@tibs245 tibs245 tibs245 approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aottr @tibs245 @SimonChaumet @mhelhali-soufien