Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pci.ai.notebook): add unit tests on order funnel #14859

Open
wants to merge 1 commit into
base: feat/pci-ai-notebooks-epic
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const mockedCatalogPlanMonth: order.publicOrder.Plan = {
},
],
invoiceName: 'invoiceName1',
planCode: 'ai-notebook.flavorCPUId.minute.consumption',
planCode: 'ai-notebook.flavorBisCPUId.minute.consumption',
pricingType: order.cart.GenericProductPricingTypeEnum.consumption,
pricings: [mockedPricing],
product: 'product',
Expand All @@ -75,7 +75,7 @@ export const mockedCatalogStorageMonth: order.publicOrder.Plan = {
},
],
invoiceName: 'invoiceName2',
planCode: 'ai-notebook.flavorCPUId.minute.consumption',
planCode: 'ai-notebook.flavorGPUId.minute.consumption',
pricingType: order.cart.GenericProductPricingTypeEnum.consumption,
pricings: [mockedPricing],
product: 'product',
Expand All @@ -95,7 +95,7 @@ export const mockedCatalogStorageHour: order.publicOrder.Plan = {
},
],
invoiceName: 'invoiceName3',
planCode: 'ai-notebook.flavorCPUId.minute.consumption',
planCode: 'ai-notebook.flavorOtherCpuId.minute.consumption',
pricingType: order.cart.GenericProductPricingTypeEnum.consumption,
pricings: [mockedPricing],
product: 'product',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as ai from '@/types/cloud/project/ai';
export const mockedEditor: ai.capabilities.notebook.Editor = {
description: 'description',
docUrl: 'docURl',
id: 'editorId',
id: 'jupyterlab',
logoUrl: 'logo',
name: 'EditorName',
versions: ['version'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as ai from '@/types/cloud/project/ai';
export const mockedFramework: ai.notebook.Framework = {
description: 'description',
docUrl: 'docURl',
id: 'frameworkId',
id: 'one-for-all',
logoUrl: 'logo',
name: 'FrameworkName',
versions: ['version'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const mockedSuggestion: Suggestions[] = [
region: 'GRA',
ressources: {
nb: 1,
flavor: 'l4-1-gpu',
flavor: 'flavorCPUId',
},
framework: {
id: 'one-for-all',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('orderFunnelHelper', () => {

const notebookSpecInputCPU: ai.notebook.NotebookSpecInput = {
env: {
editorId: 'editorId',
editorId: 'jupyterlab',
frameworkId: 'noId',
frameworkVersion: '',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ const Notebook = () => {
});

const loading =
regionsQuery.isLoading ||
catalogQuery.isLoading ||
frameworkQuery.isLoading ||
editorQuery.isLoading ||
sshKeyQuery.isLoading ||
suggestionsQuery.isLoading;
regionsQuery.isPending ||
catalogQuery.isPending ||
frameworkQuery.isPending ||
editorQuery.isPending ||
sshKeyQuery.isPending ||
suggestionsQuery.isPending;

return (
<>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,269 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import {
act,
fireEvent,
render,
screen,
waitFor,
} from '@testing-library/react';

import Notebook, {
breadcrumb as Breadcrumb,
} from '@/pages/notebooks/create/Create.page';

import { Locale } from '@/hooks/useLocale';
import { RouterWithQueryClientWrapper } from '@/__tests__/helpers/wrappers/RouterWithQueryClientWrapper';

import { mockedUser } from '@/__tests__/helpers/mocks/user';
import { mockedCatalog } from '@/__tests__/helpers/mocks/catalog';
import { mockedPciProject } from '@/__tests__/helpers/mocks/project';
import { mockedSuggestion } from '@/__tests__/helpers/mocks/suggestion';
import {
mockedCapabilitiesRegionBHS,
mockedCapabilitiesRegionGRA,
} from '@/__tests__/helpers/mocks/region';
import {
mockedEditor,
mockedEditorBis,
} from '@/__tests__/helpers/mocks/notebook/editor';
import {
mockedFramework,
mockedFrameworkBis,
} from '@/__tests__/helpers/mocks/notebook/framework';
import {
mockedSshKey,
mockedSshKeyBis,
} from '@/__tests__/helpers/mocks/sshkey';
import { mockedCommand } from '@/__tests__/helpers/mocks/command';
import { mockedCapabilitiesFlavorCPU } from '@/__tests__/helpers/mocks/flavor';
import {
mockedDatastoreWithContainerGit,
mockedDatastoreWithContainerS3,
} from '@/__tests__/helpers/mocks/datastore';
import * as notebookApi from '@/data/api/ai/notebook/notebook.api';
import { apiErrorMock } from '@/__tests__/helpers/mocks/aiError';
import { useToast } from '@/components/ui/use-toast';

const mockedUsedNavigate = vi.fn();
describe('Order funnel page', () => {
beforeEach(() => {
vi.restoreAllMocks();

// Mock necessary hooks and dependencies
vi.mock('react-i18next', () => ({
useTranslation: () => ({
t: (key: string) => key,
}),
Trans: ({ children }: { children: React.ReactNode }) => children,
}));
vi.mock('@ovh-ux/manager-react-shell-client', async (importOriginal) => {
const mod = await importOriginal<
typeof import('@ovh-ux/manager-react-shell-client')
>();
return {
...mod,
useShell: vi.fn(() => ({
i18n: {
getLocale: vi.fn(() => Locale.fr_FR),
onLocaleChange: vi.fn(),
setLocale: vi.fn(),
},
environment: {
getEnvironment: vi.fn(() => ({
getUser: vi.fn(() => mockedUser),
})),
},
})),
};
});

const ResizeObserverMock = vi.fn(() => ({
observe: vi.fn(),
unobserve: vi.fn(),
disconnect: vi.fn(),
}));
vi.stubGlobal('ResizeObserver', ResizeObserverMock);

vi.mock('react-router-dom', async () => {
const mod = await vi.importActual('react-router-dom');
return {
...mod,
useParams: () => ({
projectId: 'projectId',
}),
useNavigate: () => mockedUsedNavigate,
};
});

vi.mock('@/data/api/project/project.api', () => {
return {
getProject: vi.fn(() => mockedPciProject),
};
});

vi.mock('@/data/api/ai/notebook/notebook.api', () => ({
getCommand: vi.fn(() => mockedCommand),
addNotebook: vi.fn((notebook) => notebook),
}));

vi.mock('@/data/api/ai/notebook/suggestions.api', () => ({
getSuggestions: vi.fn(() => mockedSuggestion),
}));

vi.mock('@/data/api/catalog/catalog.api', () => ({
catalogApi: {
getCatalog: vi.fn(() => mockedCatalog),
},
}));

vi.mock('@/data/api/ai/capabilities.api', () => ({
getRegions: vi.fn(() => [
mockedCapabilitiesRegionGRA,
mockedCapabilitiesRegionBHS,
]),
}));

vi.mock('@/data/api/ai/notebook/capabilities/framework.api', () => ({
getFramework: vi.fn(() => [mockedFramework, mockedFrameworkBis]),
}));

vi.mock('@/data/api/ai/notebook/capabilities/editor.api', () => ({
getEditor: vi.fn(() => [mockedEditor, mockedEditorBis]),
}));

vi.mock('@/data/api/ai/capabilities.api', () => ({
getRegions: vi.fn(() => [
mockedCapabilitiesRegionGRA,
mockedCapabilitiesRegionBHS,
]),
getFlavor: vi.fn(() => [mockedCapabilitiesFlavorCPU]),
}));

vi.mock('@/data/api/ai/datastore.api', () => ({
getDatastores: vi.fn(() => [
mockedDatastoreWithContainerGit,
mockedDatastoreWithContainerS3,
]),
}));

vi.mock('@/data/api/sshkey/sshkey.api', () => ({
getSshkey: vi.fn(() => [mockedSshKey, mockedSshKeyBis]),
}));

vi.mock('@/components/ui/use-toast', () => {
const toastMock = vi.fn();
return {
useToast: vi.fn(() => ({
toast: toastMock,
})),
};
});

const mockScrollIntoView = vi.fn();
window.HTMLElement.prototype.scrollIntoView = mockScrollIntoView;
});
afterEach(() => {
vi.clearAllMocks();
});

it('renders the breadcrumb component', async () => {
const translationKey = 'breadcrumb';
render(<Breadcrumb />, { wrapper: RouterWithQueryClientWrapper });
await waitFor(() => {
expect(screen.getByText(translationKey)).toBeInTheDocument();
});
});

it('renders the skeleton component while loading', async () => {
render(<Notebook />, { wrapper: RouterWithQueryClientWrapper });
await waitFor(() => {
expect(screen.getByTestId('order-funnel-skeleton')).toBeInTheDocument();
});
});

it('renders the order funnel', async () => {
render(<Notebook />, { wrapper: RouterWithQueryClientWrapper });
await waitFor(() => {
expect(screen.getByTestId('order-funnel-container')).toBeInTheDocument();
expect(screen.getByTestId('name-section')).toBeInTheDocument();
expect(screen.getByTestId('flavor-section')).toBeInTheDocument();
expect(screen.getByTestId('region-section')).toBeInTheDocument();
expect(screen.getByTestId('framework-section')).toBeInTheDocument();
expect(screen.getByTestId('editor-section')).toBeInTheDocument();
expect(screen.getByTestId('advance-config-section')).toBeInTheDocument();
expect(screen.getByTestId('order-submit-button')).toBeInTheDocument();
});
});

it('trigger toast error on getCommand API Error', async () => {
vi.mocked(notebookApi.getCommand).mockImplementation(() => {
throw apiErrorMock;
});
render(<Notebook />, { wrapper: RouterWithQueryClientWrapper });
await waitFor(() => {
expect(screen.getByTestId('order-funnel-container')).toBeInTheDocument();
});
act(() => {
fireEvent.click(screen.getByTestId('advanced-config-button'));
});
act(() => {
fireEvent.click(screen.getByTestId('cli-command-button'));
});
await waitFor(() => {
expect(notebookApi.getCommand).toHaveBeenCalled();
expect(useToast().toast).toHaveBeenCalledWith({
title: 'errorGetCommandCli',
description: apiErrorMock.response.data.message,
variant: 'destructive',
});
});
});

it('trigger getCommand on Cli Command button click', async () => {
render(<Notebook />, { wrapper: RouterWithQueryClientWrapper });
await waitFor(() => {
expect(screen.getByTestId('order-funnel-container')).toBeInTheDocument();
});
act(() => {
fireEvent.click(screen.getByTestId('cli-command-button'));
});
await waitFor(() => {
expect(notebookApi.getCommand).toHaveBeenCalled();
});
});

it('trigger toast error on addNotebook API Error', async () => {
vi.mocked(notebookApi.addNotebook).mockImplementation(() => {
throw apiErrorMock;
});
render(<Notebook />, { wrapper: RouterWithQueryClientWrapper });
await waitFor(() => {
expect(screen.getByTestId('order-funnel-container')).toBeInTheDocument();
});
act(() => {
fireEvent.click(screen.getByTestId('order-submit-button'));
});
await waitFor(() => {
expect(notebookApi.addNotebook).toHaveBeenCalled();
expect(useToast().toast).toHaveBeenCalledWith({
title: 'errorCreatingNotebook',
description: apiErrorMock.response.data.message,
variant: 'destructive',
});
});
});

it('trigger add notebook on click', async () => {
render(<Notebook />, { wrapper: RouterWithQueryClientWrapper });
await waitFor(() => {
expect(screen.getByTestId('order-funnel-container')).toBeInTheDocument();
});
act(() => {
fireEvent.click(screen.getByTestId('order-submit-button'));
});
await waitFor(() => {
expect(notebookApi.addNotebook).toHaveBeenCalled();
});
expect(mockedUsedNavigate).toHaveBeenCalledWith('../undefined');
});
});
Loading
Loading