Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci.ai.notebook): add unit test on containers and public git #14847

Merged
merged 2 commits into from
Jan 9, 2025
Merged

feat(pci.ai.notebook): add unit test on containers and public git #14847

merged 2 commits into from
Jan 9, 2025

Conversation

abullet33
Copy link
Contributor

REF:DATATR-1820, DATATR-1821

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@abullet33
feat(pci.ai.notebook): add unit test on containers and public git
5303cc6 
REF:DATATR-1820, DATATR-1821
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33 abullet33 requested review from a team as code owners January 9, 2025 11:13
@abullet33 abullet33 requested review from acavalloni, MaximeBajeux, kqesar and seven-amid and removed request for a team January 9, 2025 11:13
@github-actions github-actions bot added the feature New feature label Jan 9, 2025
@abullet33
feat(pci.ai.notebook): add unit test on containers and public git
87e1d23 
REF:DATATR-1820, DATATR-1821
Signed-off-by: Arthur Bullet <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
32.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@abullet33 abullet33 merged commit cb2dd87 into feat/pci-ai-notebooks-epic Jan 9, 2025
13 of 14 checks passed
@abullet33 abullet33 deleted the feat/pci-ai-notebook-volumes-unit-test branch January 9, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jperchoc jperchoc jperchoc approved these changes

@acavalloni acavalloni Awaiting requested review from acavalloni acavalloni is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abullet33 @jperchoc