feat(vrack-services): refactor codebase to follow best practices #14784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-16503 Signed-off-by: Quentin Pavy <[email protected]>
qpavy
requested review from
MaximeBajeux,
oalkabouss,
kqesar,
seven-amid and
darsene
chipp972
reviewed
Jan 6, 2025
packages/manager/apps/vrack-services/src/components/OrderSubmitModalContent.component.tsx
Outdated
Show resolved
Hide resolved
chipp972
reviewed
Jan 6, 2025
packages/manager/apps/vrack-services/src/components/OrderSubmitModalContent.component.tsx
Outdated
Show resolved
Hide resolved
mhelhali-soufien
previously approved these changes
Jan 6, 2025
chipp972
reviewed
Jan 6, 2025
chipp972
reviewed
Jan 6, 2025
packages/manager/apps/vrack-services/src/data/hooks/useCreateCart.ts
Outdated
Show resolved
Hide resolved
chipp972
reviewed
Jan 6, 2025
packages/manager/apps/vrack-services/src/data/hooks/useCreateCart.ts
Outdated
Show resolved
Hide resolved
chipp972
reviewed
Jan 6, 2025
| ...params, | ||
| }); | ||
|
|
||
| if (createCartResponse.contractList.length === 0) |
There was a problem hiding this comment.
if it doesn't we should throw an error ?
There was a problem hiding this comment.
nop, the useCreateCart just return the response if there is contract. then the ui will show the contract list for customer approval. In case there is no contract, we keep the next steps by making the order directly
ref: MANAGER-16503 Signed-off-by: Quentin Pavy <[email protected]>
qpavy
force-pushed
the
feat/MANAGER-16503
branch
from
2916fc9 to
85a5539
Compare
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| useUpdateVrackServices, | ||
| useVrackService, | ||
| } from '@/data'; | ||
| import { getVrackServicesResourceQueryKey } from '@/data/api'; |
Check failure
Code scanning / SonarCloud
OVH keys should not be disclosed High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master[ ] Only FR translations have been updated[ ] Breaking change is mentioned in relevant commitsDescription
Refactor of folder structures:
Related