Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pci kubernetes multiple fix tapc 2080 #14731

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Feat/pci kubernetes multiple fix tapc 2080 #14731

merged 3 commits into from
Jan 17, 2025

Conversation

ppprevost
Copy link
Contributor

@ppprevost ppprevost commented Dec 27, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets TAPC-2080 TAPC-2083 TAPC-2441
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@ppprevost ppprevost requested review from a team as code owners December 27, 2024 09:41
@github-actions github-actions bot added the feature New feature label Dec 27, 2024
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_multiple-fix_tapc-2080 branch from 7b27289 to 3f27827 Compare December 27, 2024 09:45
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_multiple-fix_tapc-2080 branch 3 times, most recently from a1a380b to cb56efa Compare January 6, 2025 14:33
Eric-ciccotti
Eric-ciccotti previously approved these changes Jan 6, 2025
View reviewed changes
SimonChaumet
SimonChaumet previously approved these changes Jan 6, 2025
View reviewed changes
@ppprevost ppprevost dismissed stale reviews from SimonChaumet and Eric-ciccotti via 94b66c3 January 8, 2025 09:19
tibs245
tibs245 previously approved these changes Jan 8, 2025
View reviewed changes
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_multiple-fix_tapc-2080 branch from 94b66c3 to ee16f51 Compare January 8, 2025 15:38
@ppprevost ppprevost requested a review from a team as a code owner January 8, 2025 15:38
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_multiple-fix_tapc-2080 branch from ee16f51 to 87d520b Compare January 8, 2025 15:41
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 8, 2025
Pierre-Philippe added 2 commits January 8, 2025 16:42
feat(pci.kubernetes): replace by undefined
eb449fa 
ref: TAPC-2080
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci.kubernetes): fix pr
d8bc977 
ref: TAPC-2080
Signed-off-by: Pierre-Philippe <[email protected]>
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_multiple-fix_tapc-2080 branch from 87d520b to d8bc977 Compare January 8, 2025 15:42
@ppprevost ppprevost changed the base branch from master to develop January 8, 2025 15:43
feat(pci.kubernetes): fix network id
d1841ea 
ref: TAPC-2080
Signed-off-by: Pierre-Philippe <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fredericvilcot
Copy link
Contributor

@ppprevost
As some of your commits are not relevant anymore, could you please squash them into one?

@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w4 January 17, 2025 06:58
@anooparveti anooparveti merged commit f9b1f64 into release/public-cloud-w4 Jan 17, 2025
18 checks passed
@anooparveti anooparveti deleted the feat/pci-kubernetes_multiple-fix_tapc-2080 branch January 17, 2025 07:18
@anooparveti anooparveti mentioned this pull request Jan 17, 2025
Merged
11 tasks
acavalloni pushed a commit that referenced this pull request Jan 20, 2025
@ppprevost @acavalloni
fix(pci-kubernetes): reset cluster (#14731)
1e87e1a 
Reset cluster with public network
ref: TAPC-2080, TAPC-2083, TAPC-2441

Signed-off-by: Pierre-Philippe <[email protected]>
aottr pushed a commit that referenced this pull request Jan 21, 2025
@ppprevost @aottr
fix(pci-kubernetes): reset cluster (#14731)
5be0e1f 
Reset cluster with public network
ref: TAPC-2080, TAPC-2083, TAPC-2441

Signed-off-by: Pierre-Philippe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@tibs245 tibs245 tibs245 approved these changes

@Eric-ciccotti Eric-ciccotti Eric-ciccotti left review comments

@SimonChaumet SimonChaumet SimonChaumet left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ppprevost @fredericvilcot @tibs245 @SimonChaumet @Eric-ciccotti @anooparveti