Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-load-balancer): Load Balancer 3AZ beta #14703

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

feat(pci-load-balancer): Load Balancer 3AZ beta #14703

wants to merge 11 commits into from

Conversation

Tsiorifamonjena
Copy link
Contributor

@Tsiorifamonjena Tsiorifamonjena commented Dec 23, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-2270, #TAPC-1523, #TAPC-2486
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • TAPC-2270
  • TAPC-1523
  • TAPC-2486

Related

@Tsiorifamonjena
feat(pci.load-balancer): use regionselector for loadbalancer
101e460 
ref: TAPC-2270
Signed-off-by: tsiorifamonjena <[email protected]>
@Tsiorifamonjena
feat(pci.load-balancer): clean useless code
15eefe1 
ref: TAPC-2270
Signed-off-by: tsiorifamonjena <[email protected]>
@Tsiorifamonjena
feat(pci.load-balancer): fix unit test
b44cfeb 
ref: TAPC-2270
Signed-off-by: tsiorifamonjena <[email protected]>
@Tsiorifamonjena
Merge pull request #14692 from ovh/feat/pci-load-balancer_3AZ_tapc-2270
83582cd 
feat(pci-load-balancer): [Load Balancer 3AZ] - Configuration page - Add 3-AZ tag
@Tsiorifamonjena
feat(pci.load-balancer): add warning message for no net region
8f3e659 
ref: TAPC-1523
Signed-off-by: tsiorifamonjena <[email protected]>
@Tsiorifamonjena
feat(pci.load-balancer): fix unit test
57e0ab9 
ref: TAPC-1523
Signed-off-by: tsiorifamonjena <[email protected]>
@Tsiorifamonjena
Merge pull request #14699 from ovh/feat/pci-load-balancer_config_tapc…
5c5df79 
…-1523

feat(pci-load-balancer): Configuration page - Notify user if location selected has no private network
@Tsiorifamonjena Tsiorifamonjena requested review from a team as code owners December 23, 2024 08:53
@Tsiorifamonjena
feat(pci.load-balancer): add free banner price for paris az
e080185 
ref: TAPC-2486
Signed-off-by: tsiorifamonjena <[email protected]>
@Tsiorifamonjena
Merge pull request #14705 from ovh/feat/pci-load-balancer_3AZ_tapc-2486
55bd687 
feat(pci.load-balancer): [Load Balancer 3AZ] - Configuration page - Add a banner for Paris-3-AZ Beta
@Tsiorifamonjena
feat(pci-load-balancer): add 1az tooltip key
6142046 
ref: TAPC- 2270

Signed-off-by: tsiorifamonjena <[email protected]>
qpavy
qpavy previously approved these changes Dec 24, 2024
View reviewed changes
lionel95200x
lionel95200x previously approved these changes Dec 24, 2024
View reviewed changes
oalkabouss
oalkabouss previously approved these changes Dec 26, 2024
View reviewed changes
@Tsiorifamonjena Tsiorifamonjena marked this pull request as draft January 6, 2025 11:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oalkabouss oalkabouss oalkabouss left review comments

@lionel95200x lionel95200x lionel95200x left review comments

@qpavy qpavy qpavy left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tsiorifamonjena @qpavy @lionel95200x @oalkabouss