Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): change protection level subtile translation #14650

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat(kms): change protection level subtile translation #14650

merged 2 commits into from
Jan 10, 2025

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Dec 18, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-16192
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

🎏 Translations

  •  CMT-20039

@tibs245 tibs245 requested a review from a team as a code owner December 18, 2024 14:42
anooparveti
anooparveti previously approved these changes Dec 19, 2024
View reviewed changes
@tibs245
feat(kms): change protection level subtile translation
1246c5f 
ref: MANAGER-16192

Signed-off-by: Thibault Barske <[email protected]>
@tibs245 tibs245 force-pushed the feat/kms-protection-level-translation branch from 6163c9f to 1246c5f Compare December 19, 2024 08:13
ThibaudCrespin
ThibaudCrespin previously approved these changes Dec 19, 2024
View reviewed changes
@antleblanc antleblanc dismissed stale reviews from ThibaudCrespin and anooparveti via 050e196 January 6, 2025 11:44
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@darsene darsene changed the base branch from develop to release/hpc-enabler-w3 January 10, 2025 11:02
@darsene darsene merged commit 9565611 into release/hpc-enabler-w3 Jan 10, 2025
18 of 20 checks passed
@darsene darsene deleted the feat/kms-protection-level-translation branch January 10, 2025 11:21
@darsene darsene mentioned this pull request Jan 10, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@pauldkn pauldkn pauldkn approved these changes

@ThibaudCrespin ThibaudCrespin ThibaudCrespin approved these changes

@anooparveti anooparveti anooparveti left review comments

@aottr aottr Awaiting requested review from aottr aottr is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
enabler feature New feature quality check: ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tibs245 @ThibaudCrespin @anooparveti @pauldkn @darsene