fix(hub-react): adapted skeletons display to reduce cls kpi #14275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anooparveti
requested changes
Dec 3, 2024
packages/manager/apps/hub-react/src/components/hub-order-tracking/OrderTracking.skeleton.tsx
Outdated
Show resolved
Hide resolved
JacquesLarique
force-pushed
the
fix/hub-skeletons
branch
from
9f80a2c to
bd7b051
Compare
anooparveti
reviewed
Dec 20, 2024
...ages/manager/apps/hub-react/src/components/hub-order-tracking/HubOrderTracking.component.tsx
Show resolved
Hide resolved
anooparveti
previously approved these changes
Jan 7, 2025
github-actions
bot
added
the
has conflicts
added 6 commits
January 8, 2025 11:27
ref: MANAGER-15784 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-15784 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-15784 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-15784 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-15784 Signed-off-by: Jacques Larique <[email protected]>
ref: MANAGER-15784 Signed-off-by: Jacques Larique <[email protected]>
JacquesLarique
force-pushed
the
fix/hub-skeletons
branch
from
870db94 to
eaacaea
Compare
github-actions
bot
removed
the
has conflicts
|
MaximeBajeux
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterOnly FR translations have been updated(n/a)Breaking change is mentioned in relevant commits(n/a)Description
Reorganized skeletons in order to match as best as possible the final display of the page to reduce / enhance CLS Web Vital
Related