WIP: Protochunk rendering - addresses #2002, #2024, #2035 #2047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses (and most likely fixes) #2002, #2024, and #2035. It does so by:
render_protochunks
prettify_protochunk_lighting
render_protochunks
is enabled, also rendering chunks with a status of"empty"
or"structure_starts"
.prettify_protochunk_lighting
is enabled, attempting to fix lighting issues with dark border chunksCaveats:
World
s andRegionSet
s now need to remember these config options, as the change must be made thereReasons why this PR is a draft:
Nevertheless, some previews!
render_protochunks=False
,prettify_protochunk_lighting=False
(equivalent to current):render_protochunks=True
,prettify_protochunk_lighting=False
:render_protochunks=True
,prettify_protochunk_lighting=True
:The world I used for rendering is attached here:
mcov-test-118chunks-118-forceupgrade.zip
I made it by creating a new world in 1.17, teleporting to x/z=0/1024, teleporting back to 0/0, reopening the world in 1.18, and then optimizing it.
I am also re-rendering https://map.wurstmineberg.de with these options enabled, although that will take a few days.