fix: add variable.scss file path of cms and remove account and profile MFE #90
Conversation
hinakhadim
force-pushed
the
hina/fix-nightly
branch
from
5da8b8c to
0ac3899
Compare
hinakhadim
force-pushed
the
hina/fix-nightly
branch
from
0ac3899 to
bf782bf
Compare
| @@ -0,0 +1 @@ | |||
| - [BugFix] Add variable.scss file path of edx-platform for CMS and remove header and footer of profile and account MFE (by @hinakhadim) | |||
There was a problem hiding this comment.
please update the changelog as we are no longer removing the header/footer in the PR.
There was a problem hiding this comment.
Current nightly branch has header and footer. We have to remove them in nightly
There was a problem hiding this comment.
Ah, got it. I was remembering it when they were removed previously, I did not see they have been added back.
There was a problem hiding this comment.
Because master is merged into nightly.
|
|
||
| $uxpl-pink-base: rgb(194, 56, 125) !default; // wcag2a compliant | ||
| $uxpl-pink-hover-active: lighten($uxpl-pink-base, 7%) !default; // wcag2a compliant | ||
|
|
||
| $uxpl-grayscale-x-back: rgb(245, 245, 245) !default; // UXPL grayscale, x-back | ||
|
|
There was a problem hiding this comment.
I assume all of these variables are now coming from cms/static/sass/partials/cms/theme/variables-v1?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, add import cms/static/sass/partials/cms/theme/variables-v1 at the top. Only those variables exists that we've overrided.
This PR fixes the
Undefined variable: "$color-hide-from-toc"and also removes the header, the footer of profile and account MFE