fix: add patches folder to manifest.in to be available on pip install #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| - [Bug] Fix env.config.jsx for dark theme and Indigo footer by including the patches folder in MANIFEST.in for python pypi package. (by @hinakhadim) | |||
There was a problem hiding this comment.
nit: Bugfix, not bug.
DawoudSheraz
approved these changes
Jan 24, 2025
|
Great catch! Let's publish a v19.0.1 ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing tutor-indigo via pip install tutor-indigo, the patches folder is not included in the tar.gz package.
Effect:
Cause:
The
env.config.jsxfile requires imports and the AddDarkTheme component, which are located in the patches folder. Since the patches folder is not being downloaded with the installation,env.config.jsxdoes not produce the expected output.