Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brick: ignore tap_burst error #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

brick: ignore tap_burst error #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/brick.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,8 +567,11 @@ static void do_unlink(struct pg_brick *brick, enum pg_side side, uint16_t index,
return;

unlink_notify(pair_edge, pg_flip_side(side), errp);

/* TODO: This error come from tap_bust. But the goal here is to */
/* unlink brick. We will find the best way to ignore this error soon */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will find the best way to ignore this error soon
...
yeah we all know that's a lie

if (pg_error_is_set(errp))
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pg_error_free otherwise it would leak

*errp = NULL;

pg_brick_decref(brick, errp);

Expand Down