Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toast style #127

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Update toast style #127

merged 2 commits into from
Sep 2, 2024

Conversation

YayunHuang
Copy link
Contributor

@YayunHuang YayunHuang commented Sep 2, 2024 •
edited
Loading

Ref: MUP-186

Screenshot 2024-09-02 at 10 09 01 AM Screenshot 2024-09-01 at 10 43 54 PM

@YayunHuang YayunHuang requested a review from pkong-ds September 2, 2024 02:07
pkong-ds
pkong-ds reviewed Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@pkong-ds pkong-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image This feels very weird. If there are no mockups, should we stay at `device upload page` and tell user to change his uploads again?

And I thought we handled this in MUP-150. Is this a regression?

@YayunHuang YayunHuang force-pushed the 186-update-popup-style branch from e7f9188 to f0d7d74 Compare September 2, 2024 05:08
@YayunHuang
Copy link
Contributor Author

@pkong-ds updated, move handleNoGeneratedMockup to upload page, and won't redirect to download page when no generated mockup

Screen.Recording.2024-09-02.at.1.00.19.PM.mov

pkong-ds
pkong-ds approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@pkong-ds pkong-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot yayun. The code in this commit looks very clean and easy to read thanks to your previous refactoring 🙏

LGTM!

@pkong-ds pkong-ds merged commit e4706ee into oursky:main Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkong-ds pkong-ds pkong-ds approved these changes

Assignees

@pkong-ds pkong-ds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YayunHuang @pkong-ds