Change cdn to npm package POC #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase |
YayunHuang
force-pushed
the
161-change-cdn-to-npm-package-poc
branch
from
1820dd4 to
6532db6
Compare
|
@pkong-ds rebased |
pkong-ds
reviewed
Aug 27, 2024
Comment on lines
+44
to
+46
| var dataurlkey = await allStorage(); | ||
| dataurlkey.forEach(function (value, key) { | ||
| file = dataURLtoFile(value, key.substring(3, key.length) + ".png"); | ||
| var file = dataURLtoFile(value, key.substring(3, key.length) + ".png"); |
There was a problem hiding this comment.
const/let does not work?
There was a problem hiding this comment.
can work, but other places in this file all using var 😅, I can update them all at once when changing .js to .ts`
YayunHuang
force-pushed
the
161-change-cdn-to-npm-package-poc
branch
from
6532db6 to
a342675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by
/public#110What's in this PR?
Ref: MUP-161
change cdns in
download-python-package.js:upload.jsso didn't remove cdn file)