Proof of concept of using client-side script in astro #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkong-ds
commented
Aug 26, 2024
There was a problem hiding this comment.
@YayunHuang think there are 2 approaches I have. See if you can think of others/pick one here?
Also, please make sure lint still work on these ts files 🙏
There was a problem hiding this comment.
Approach 1
- keep scripts in
src/pages - name
ts/jsfiles usingdocumentorwindowwith_prefxi
There was a problem hiding this comment.
Approach 2
- Move all astro files into other folders, e.g.
src/componetns- Maybe even better, move all pages to
src/astro-pages/- e.g.
src/astro-pages/DeveloperToolsPage.astro - then, in
src/pages/developerTools/index.astro, only import thesrc/astro-pages/DeveloperToolsPage.astrow/o any extra logic - that way, we can work around
src/pagesproblem
- e.g.
- Maybe even better, move all pages to
rationale: only src/pages scripts are buggy
|
@pkong-ds seems approach 2 won't work too, I tried to put the pages to |
|
As per offline discussion, will use approach 1. Lemme close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for demo purpose, will close after @YayunHuang read it.