Let CD depends on CI #109
Merged
Let CD depends on CI #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkong-ds
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Did you reference from https://github.com/oursky/mtr-oneclick/tree/main/.github/workflows ? 😆
.github/workflows/trigger-pr.yaml
Outdated
| group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| on: [push, pull_request] |
There was a problem hiding this comment.
trigger-pr should only need pull_request?
I suppose ci.yaml will run twice on push with this configuration, which is undesired?
- in
trigger-cicd.yaml - in
trigger-pr.yaml
Suggested change
| on: [push, pull_request] | |
| on: [pull_request] |
.github/workflows/trigger-cicd.yaml
Outdated
There was a problem hiding this comment.
discussion: filename should follow same pattern? pick one col below?
| name by what it does | name by what triggers it |
|---|---|
| trigger-cicd.yaml (or trigger-cd.yaml ?) | trigger-push.yaml |
| trigger-ci.yaml | trigger-pr.yaml |
YayunHuang
force-pushed
the
149-let-cd-depends-on-ci
branch
from
eee7073 to
8510f7b
Compare
|
@pkong-ds updated, and I pick |
pkong-ds
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: MUP-149