Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in new ROR search to funding body #2690

Merged
merged 19 commits into from
Dec 3, 2024
Merged

Conversation

lamtu1
Copy link
Contributor

@lamtu1 lamtu1 commented Sep 26, 2024

FEATURE: Add in an autocomplete search function to the new ROR search based into the funding_body.

PROGRESS:
Part 1: Display

  • Add in the new funding_body view
  • Update the JS script for autocomplete w/ funding_body
  • Create a new QA search for ROR

Part 2: CV

  • Create the control vocab for ROR
  • Update the fetch method to make the RDF::Graph & RDF::Statement
  • Be able to save onto curation_concern
  • Index the value
  • Display in work edit page

Part 3: Test

  • Make sure it holds value
  • Make sure it display on show page
  • Make sure it display in search on SA
  • Make sure the facet is not an URI but with label
  • Create spec if needed

@lamtu1 lamtu1 self-assigned this Sep 26, 2024
@lamtu1 lamtu1 marked this pull request as draft September 26, 2024 22:26
@lamtu1
Copy link
Contributor Author

lamtu1 commented Sep 26, 2024

fixes #2604

@lamtu1 lamtu1 force-pushed the feature/rorFundingVocab branch from b798db6 to 80b4fd8 Compare November 18, 2024 18:53
@lamtu1 lamtu1 marked this pull request as ready for review November 20, 2024 20:44
@lamtu1 lamtu1 marked this pull request as draft November 20, 2024 20:45
@lamtu1
Copy link
Contributor Author

lamtu1 commented Nov 20, 2024

IMAGE: Screenshot of showing the progress of the new Vocab

Screenshot 2024-11-20 at 12 46 05 PM Screenshot 2024-11-20 at 12 46 37 PM

@lamtu1 lamtu1 marked this pull request as ready for review November 22, 2024 19:07
@straleyb straleyb merged commit 6ddc636 into main Dec 3, 2024
4 checks passed
@straleyb straleyb deleted the feature/rorFundingVocab branch December 3, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants