Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace chart js with material charts #141

Closed
wants to merge 11 commits into from

Conversation

andra-sava
Copy link
Contributor

@andra-sava andra-sava commented Nov 19, 2024

Replaced chart.js and react-chartjs-2 with charts from @mui/x-charts

Breaking changes:

  • The following properties have been removed: width, height, data, options type
  • A new chart property (of object type) has been added, which now accepts all properties specific to the selected chart type.
  • Chart components have been removed. To use chart components, visit: https://mui.com/x/react-charts/

📜 Storybook changes:

  • Simple chart type representations have been removed. As a result, individual chart components are no longer being released separately.
  • The charts used in the stats cards are the default MUI X chart components, without any additional modifications. For more details, refer to the documentation: https://mui.com/x/react-charts/

@@ -39,14 +28,12 @@ const StatsChart: React.FC<StatsChartProps> = ({
text,
statText,
StatIcon,
type = 'line',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would let type property outside chart to keep the actual behavior.

@andra-sava andra-sava closed this Nov 20, 2024
@andra-sava andra-sava deleted the feature/ReplaceChartJsWithMaterialCharts branch November 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants