Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git extension] fix existing user_override_name key, but with None value #274

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

muritane
Copy link
Contributor

@muritane muritane commented Mar 18, 2024

When trying to git commit found out that the ~/.gitconfig file was mounted to /home/None/.gitconfig.
The corresponding test is also added.

@muritane muritane requested a review from tfoote as a code owner March 18, 2024 15:23
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced with rocker --git --user -- ros:rolling

The get method is only testing for defined, but now that the value has a default value it is defined but still None.

Thanks for the fix with a test to confirm coverage.

@tfoote tfoote merged commit 9774799 into osrf:main Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants