Skip to content

Commit

Permalink
Upgrading CI versions due to deprecated results (#228)
Browse files Browse the repository at this point in the history
* move to actions/checkout@v3
* move to actions/setup-python@v4
* Pin back urllib3<2 due to regression docker/docker-py#3113
* Remove old workaround which upstream has merged a fix for.
* upgrade codecov action to v3
* upgrade to coactions/setup-xvfb@v1

Signed-off-by: Tully Foote <[email protected]>
  • Loading branch information
tfoote authored May 4, 2023
1 parent 64e7c05 commit 2a7e15f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/basic-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,18 @@ jobs:
matrix:
python-version: [3.8, '3.10']
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v1
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install Dependencies And Self
run: |
python -m pip install --upgrade pip setuptools wheel
# Workaround for https://github.com/docker/docker-py/issues/2807
python -m pip install six
python -m pip install -e .[test] codecov pytest-cov
- name: Run headless tests
uses: GabrielBB/xvfb-action@v1
uses: coactions/setup-xvfb@v1
with:
run: python -m pytest -s -v --cov=rocker -m "not nvidia"
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
'empy',
'pexpect',
'packaging',
'urllib3<2', # Workaround for https://github.com/docker/docker-py/issues/3113
]

# docker API used to be in a package called `docker-py` before the 2.0 release
Expand Down

0 comments on commit 2a7e15f

Please sign in to comment.