Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert text/bg colors in dark mode #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grischard
Copy link
Contributor

No description provided.

@gravitystorm
Copy link
Contributor

I'd advise against doing this. White text on a black background is hard to read for some people, which is why most "dark mode" stylesheets are not-really-white on dark-grey. Black text on a white background is fine, of course.

I think this will also have issues with all the other colours on the site, such as the greys used for tables, link colours, etc etc.

I would recommend that if you want to have a dark mode for this site, that you find a third-party theme where this stuff is figured out by other people! Recent versions of bootstrap (v5.3+) have a dark mode, for example, which handles these contrast and colour theory issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants