Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyprus motorway shields #558

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc-img/shield_map_world.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
39 changes: 39 additions & 0 deletions icons/shield_hex_vert_green_yellow_2.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
39 changes: 39 additions & 0 deletions icons/shield_hex_vert_green_yellow_3.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions src/js/shield_defs.js
Original file line number Diff line number Diff line change
Expand Up @@ -3249,6 +3249,16 @@ export function loadShields(shieldImages) {
Color.shields.white
);

// Cyprus
shields["cy:national"] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

national is an unusual name for what seems to be a network of motorways. cy:motorway would be more appropriate, as would cy:A-road considering the A prefix.

It's unclear whether this tagging was invented by a Cypriot. Is there a Cyprus OSM community that we can contact about this?

Copy link
Member Author

@1ec5 1ec5 Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Wikipedia, “motorway” is equivalent to the A-road network, but it does sound like B-roads and E-roads could also be part of a national numbering scheme. Maybe this was an attempt to conform to what was perceived as international terminology (not the first time I’ve seen it). The tag was introduced in changeset 44730739.

The community index doesn’t list any local community for Cyprus, and the national tagging page doesn’t provide any guidance on route relations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to solidify a tagging scheme that may complicate tagging guidelines for the remaining route networks in Cyprus. It's unclear how other networks in Cyprus should be tagged if we decide to support cy:national.

Cyprus is a small country, and the mapping community may only be a few people. Perhaps we could ask the Greek community for their perspective—certainly some of them would be familiar with Cyprus, and if there are any Cypriot mappers, there's a chance we may find them there.

...hexagonVerticalShield,
backgroundImage: [
shieldImages.shield_hex_vert_green_yellow_2,
shieldImages.shield_hex_vert_green_yellow_3,
],
textColor: Color.shields.yellow,
};

// Czechia
shields["CZ:national"] = roundedRectShield(
Color.shields.red,
Expand Down
1 change: 1 addition & 0 deletions src/shieldtest.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ let networks = [
"ID:national",

"AU:QLD:MR",
"cy:national",
"GR:national",
"my:federal",
"TR:motorway",
Expand Down