overrideByName causes legend to omit shields #1165 #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @joshuamanivinod for the contribution. Do we know why the shield is shifted to the right compared to the others? |
|
It looks like two images are being displayed side by side, which is causing the image to appear slightly shifted. I'm trying to determine the reason for this issue.
|
|
Handle overrideByName causing legend to omit shields
|
ZeLonewolf
previously requested changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @1ec5
I have implemented a fix for this issue. The updated logic ensures that shields appear correctly in the legend even when a network uses
overrideByName. Specifically, thegetSortedImagesfunction now accounts foroverrideByNamealongside existing overrides, ensuring no blank spaces are shown.Let me know if this solution meets your expectations or if further adjustments are needed.