Serialization Refactor #4162
Serialization Refactor #4162
Conversation
antonydellavecchia
force-pushed
the
adv/ipc-serialize
branch
from
02b2191 to
d758fad
Compare
antonydellavecchia
force-pushed
the
adv/ipc-serialize
branch
from
47e3f3f to
66a5f2e
Compare
Thanks @antonydellavecchia. |
src/Serialization/LieTheory.jl
Outdated
| @@ -112,36 +93,27 @@ end | |||
|
|
|||
| @register_serialization_type WeylGroup uses_id | |||
|
|
|||
| type_params(W::WeylGroup) = WeylGroup, root_system(W) | |||
There was a problem hiding this comment.
Stupid question maybe: It seems to me that the first return value of type_params is always the argument type. Is this a correct observation?
If yes, wouldn't it be possible to refactor that away into the calling function, so that type_params loses the first return value? Imo, this could make the code a bit more readable. If there is a reason for this, I am happy to learn about it
There was a problem hiding this comment.
maybe there is a way to get a round it, but it was the only way I found I could get the new save_type_params to work. See main.jl
src/Serialization/main.jl
Outdated
| save_data_dict(s, :attrs) do | ||
| for attr in attrs_list(s, T) | ||
| has_attribute(obj, attr) && save_typed_object(s, get_attribute(obj, attr), attr) | ||
| save_type_params(s::SerializerState, obj::Any) = save_type_params(s, type_params(obj)...) |
There was a problem hiding this comment.
| save_type_params(s::SerializerState, obj::Any) = save_type_params(s, type_params(obj)...) | |
| save_type_params(s::SerializerState, obj::Any) = save_type_params(s, typeof(obj), type_params(obj)...) |
I think this could do the trick
There was a problem hiding this comment.
yes this is probably fine
There was a problem hiding this comment.
actually, a little trickier than expected, there is an issue with the containers.
I'll have to dig deeper, but I dont have time now
There was a problem hiding this comment.
I've pushed a fix for this now
antonydellavecchia
force-pushed
the
adv/ipc-serialize
branch
from
af1675c to
215e946
Compare
Refactor serialization to use a new function called
type_paramswhich helps build a stack of type dependencies which will allow for serializing type information before the data.