Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump to Go 1.22 and simplify prepare-sources.sh #4551

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lzap
Copy link
Contributor

@lzap lzap commented Jan 9, 2025

Updates Go to 1.22, this is pretty straightforward.

Modifies prepare-sources.sh to avoid downloading of a specific Go version, if I understand this correctly it is no longer necessary. This document explains it even better. Let's try and revert this back if it does not work?

Updated all deps, oapi-gen now prints a warning that v1->v2 upgrade is needed. Since these upgrades can bite, created an issue for this.

Other than that, it is must a massive vendor/ update.

@lzap lzap force-pushed the go122 branch 3 times, most recently from 396145b to 12b8691 Compare January 9, 2025 17:56
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick drive-by: I think it might be a bit nicer to split this in two commits, one for prepare-sources.sh and one with the rest of the (mostly mechanical?) changes.

@lzap
Copy link
Contributor Author

lzap commented Jan 9, 2025

Good idea, we might need to revert that change if it turns to be problematic. Done.

bcl
bcl previously approved these changes Jan 11, 2025
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, restarted the failing schutzbot tests...

@lzap lzap enabled auto-merge (rebase) January 13, 2025 14:53
@lzap
Copy link
Contributor Author

lzap commented Jan 15, 2025

RPM builds were failing:

go.mod requires go >= 1.22.10 (running go 1.22.9; GOTOOLCHAIN=local)

Downgraded minor version requirement.

@lzap
Copy link
Contributor Author

lzap commented Jan 15, 2025

Fixed RPM builds but still failing.

@lzap
Copy link
Contributor Author

lzap commented Jan 15, 2025

Note for myself: rebase after #4559 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants