-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump to Go 1.22 and simplify prepare-sources.sh #4551
base: main
Are you sure you want to change the base?
Conversation
396145b
to
12b8691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick drive-by: I think it might be a bit nicer to split this in two commits, one for prepare-sources.sh and one with the rest of the (mostly mechanical?) changes.
Good idea, we might need to revert that change if it turns to be problematic. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, restarted the failing schutzbot tests...
RPM builds were failing:
Downgraded minor version requirement. |
Fixed RPM builds but still failing. |
Note for myself: rebase after #4559 is merged |
Updates Go to 1.22, this is pretty straightforward.
Modifies prepare-sources.sh to avoid downloading of a specific Go version, if I understand this correctly it is no longer necessary. This document explains it even better. Let's try and revert this back if it does not work?
Updated all deps, oapi-gen now prints a warning that v1->v2 upgrade is needed. Since these upgrades can bite, created an issue for this.
Other than that, it is must a massive
vendor/
update.