Update osbuild/images to v0.105.0 (COMPOSER-2357, COMPOSER-2400) #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
changed the title
thozza
changed the title
This brings a lot of new stuff, among others: - Internal image types for RHEL-10 (COMPOSER-2357) - Support for Swap partitions in DiskCustomizations (COMPOSER-2400) - Support for new partitioning customizations for CS and RHEL - Fix for RHEL 8 and 9 AMI boot mode (RHEL-69628) Signed-off-by: Tomáš Hozza <[email protected]>
thozza
changed the title
|
I've updated the PR to use the latest |
Previously, the `OSTree` property in the Weldr API `ComposeRequest` struct was not a pointer to the `ostree.ImageOptions` type. As a result, it was initialized to an empty struct, even if not set in the client API call. As a result, the `OSTree` property in the `distro.ImageOptions` was always not `nil`, when initializing the osbuild manifest. However, after a change in `osbuild/images` [0], providing OSTree options for non-OSTree image types is no longer considered valid. This caused a failure to submit a new compose for any non-OSTree image type. Change the `OSTree` property in Weldr `ComposeRequest` to be a pointer and mark it as optional. [0] osbuild/images#1071 Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a lot of new stuff, among others:
This pull request includes: