Clean up orphaned instances and security groups (HMS-3632) #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuellerf
force-pushed
the
HMS-3632-clean-up-orphaned-instances
branch
4 times, most recently
from
63f34e1 to
3103a97
Compare
schuellerf
commented
Dec 4, 2024
schuellerf
commented
Dec 4, 2024
schuellerf
commented
Dec 4, 2024
croissanne
reviewed
Dec 5, 2024
croissanne
requested changes
Dec 5, 2024
There was a problem hiding this comment.
thanks, looks good overall
Could you reword this commit message though?
Usually the parent does not exist when also the secure instance is
older than 2h, but this an extra safeguard that secure instances
without a valid parent instance does not make sense to keep.
And then the jira tickets tend to just go in the PR descriptions.
I think they should be part of the commit message |
schuellerf
force-pushed
the
HMS-3632-clean-up-orphaned-instances
branch
2 times, most recently
from
ba65a81 to
7684e9e
Compare
schuellerf
force-pushed
the
HMS-3632-clean-up-orphaned-instances
branch
2 times, most recently
from
b1456a2 to
94492ab
Compare
Support running the maintenance locally with a valid `~/aws/credentials` file. HMS-3632
schuellerf
force-pushed
the
HMS-3632-clean-up-orphaned-instances
branch
from
94492ab to
fa02bac
Compare
mvo5
reviewed
Dec 9, 2024
croissanne
reviewed
Dec 9, 2024
schuellerf
force-pushed
the
HMS-3632-clean-up-orphaned-instances
branch
2 times, most recently
from
f4d001a to
ca3c904
Compare
Add a safeguard to ensure secure instances without valid parent instances are terminated, as they are unnecessary to retain. Typically, the parent does not exist if the secure instance is older than 2 hours, but this check provides additional validation. HMS-3632
Security groups of instances that are terminated should be removed. HMS-3632
Launch templates of instances that are terminated should be removed. HMS-3632
Passing an empty list to `TerminateInstances` causes an error message, which is not necessary, as there is nothing to terminate.
Collect and merge errors, instead of nesting errors. In this case we want to continue execution if only one cleanup fails.
schuellerf
force-pushed
the
HMS-3632-clean-up-orphaned-instances
branch
from
ca3c904 to
cae703a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
Implement removal of orphaned items as described in https://issues.redhat.com/browse/HMS-3632
removal of launch templates is not yet implemented (that's why it's a draft for now)