Port RHEL-7 to the common rhel package
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
previously approved these changes
Apr 12, 2024
achilleas-k
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
I initially thought we might not want this because RHEL 7 is "too different" from 8 and 9 to be merged cleanly but the actual changes here are quite small. That last commit has a large diff but it's all mostly structural changes.
Really nice that this gets unified too. Clean. Thank you!!
LGTM
|
Let's hold off merging this until #586 gets through otherwise we'll get a lot of unnecessary builds. |
achilleas-k
requested changes
Apr 12, 2024
This makes the meaning of the field more explicit. Signed-off-by: Tomáš Hozza <[email protected]>
Previously, the RHEL-7 diskImage() image kind implementation hardcoded the NoBLS setting. To be able to port RHEL-7 to the common RHEL image kind implementation, move the NoBLS setting to the default distro ImageConfig. Signed-off-by: Tomáš Hozza <[email protected]>
Some distributions use codenames for releases. Add it to the distro.Distro interface. Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
Port RHEL-7 distro to the common rhel package. Notable changes: - Pass YUM config from the ImageConfig to OSCustomizations in distro/rhel. - Pass SELinuxForceRelabel from the ImageConfig to OSCustomizations in distro/rhel. - Add DiskImageVPCForceSize and DiskImagePartTool to rhel.ImageType, since these needs to be set to non-default values for RHEL-7. Signed-off-by: Tomáš Hozza <[email protected]>
achilleas-k
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port RHEL-7 as the last distro to the common
rhelpackage.Notable changes:
NoBLStoImageConfigCodename()to thedistro.DistrointerfaceImageConfigtoOSCustomizationsin distro/rhel.SELinuxForceRelabelfrom theImageConfigtoOSCustomizationsin distro/rhel.DiskImageVPCForceSizeandDiskImagePartTooltorhel.ImageType, since these needs to be set to non-default values for RHEL-7.I compared all manifests generated on
mainandHEADof this PR and there were no changes.