many: revert PR#462 to unblock images temporarily #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that we need user customizations that go beyond what PR#462 provided. So to unblock the other work around the iso installer revert this PR temporarily and once the groundwork in osbuild is ready this commit here will be reverted and the pieces added that enable user customizations with `bootc install to-filesystem`.
|
It looks like we won't need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we need user customizations that go beyond what PR#462 provided. So to unblock the other work around the iso installer revert this PR temporarily and once the groundwork in osbuild is ready this commit here will be reverted and the pieces added that enable user customizations with
bootc install to-filesystem.[Opening this to have it available if we need it, maybe we can be quick and get osbuild/customzations ready early enough]
[edit: https://github.com/osbuild/images/compare/main...mvo5:bootc-disk-customize-again?expand=1 contains the WIP work on making the user customization work again, it needs https://github.com/osbuild/osbuild/pull/1706 too]