rpmmd: add module_hotfixes flag to RepoConfig #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
force-pushed
the
allow_module_hotfixes_flag
branch
from
7ad2d6a to
18315c5
Compare
bcl
requested changes
Nov 30, 2023
ondrejbudai
reviewed
Dec 1, 2023
The aim here was not to change the hash if the flag is not set, I've clearly failed. |
ezr-ondrej
force-pushed
the
allow_module_hotfixes_flag
branch
3 times, most recently
from
e9d57c9 to
a7913fa
Compare
ezr-ondrej
commented
Dec 1, 2023
|
Alright, we are 🍏 here, I've added a test, but quite a simle one, if you'd have an idea what else we should cover, let me know pls, so we can get this in 🙏 |
|
nit: the commit message needs |
ezr-ondrej
force-pushed
the
allow_module_hotfixes_flag
branch
from
a7913fa to
5c0a0a0
Compare
ezr-ondrej
changed the title
Hehe, true, indeed, thx, good catch 🙏 |
mvo5
previously approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Thanks for your PR! This looks fine AFAICT (take it with a grain of salt, I'm relatively new to this codebase) as a short term fix. I have some inline comments and if my assumptions are correct I would love to have a followup for them - I'm happy to volunteer if you are busy of course :)
thozza
reviewed
Dec 4, 2023
ezr-ondrej
force-pushed
the
allow_module_hotfixes_flag
branch
3 times, most recently
from
b3cdcf2 to
ad8372f
Compare
mvo5
previously approved these changes
Dec 4, 2023
thozza
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Thanks for the changes. However, I found one problem which I consider a blocker.
In addition to that, I realized that you didn't modify the dnf-json copy in this repository, which then makes the newly added repo config value be ignored by it in testing. Please modify it in the same way as you did in the osbuild-composer PR.
ezr-ondrej
force-pushed
the
allow_module_hotfixes_flag
branch
from
ad8372f to
da60f7a
Compare
Adds module_hotfixes flag to all repo types so it can be used during osbuild. This enables users to disable modularity filtering on specific repositories.
ezr-ondrej
force-pushed
the
allow_module_hotfixes_flag
branch
from
da60f7a to
508bc58
Compare
Closed
thozza
added a commit
to thozza/osbuild-images
that referenced
this pull request
Dec 5, 2023
Just testing if our current CI tests would have caught osbuild#284 (comment) Signed-off-by: Tomáš Hozza <[email protected]>
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Dec 5, 2023
This is a regression test for an issue found during the review of PR#284 [0]. The issue was that ``` ModuleHotfixes *bool `json:"module_hotfixes"` ``` lacked the required `omitempty` which may cause issues with dnfjson. As a quick and easy way to prevent this in the future this commit adds a small test that ensures that we notice any missing `omitempty`. Note that the `rpmmd` part is not strictly needed but it feels more correct to do the check in both places that use a repoConfig. [0] osbuild#284 (comment)
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Dec 5, 2023
This is a regression test for an issue found during the review of PR#284 [0]. The issue was that ``` ModuleHotfixes *bool `json:"module_hotfixes"` ``` lacked the required `omitempty` which may cause issues with dnfjson. As a quick and easy way to prevent this in the future this commit adds a small test that ensures that we notice any missing `omitempty`. Note that the `rpmmd` part is not strictly needed but it feels more correct to do the check in both places that use a repoConfig. [0] osbuild#284 (comment)
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Dec 5, 2023
This is a regression test for an issue found during the review of PR#284 [0]. The issue was that ``` ModuleHotfixes *bool `json:"module_hotfixes"` ``` lacked the required `omitempty` which may cause issues with dnfjson. As a quick and easy way to prevent this in the future this commit adds a small test that ensures that we notice any missing `omitempty`. Note that the `rpmmd` part is not strictly needed but it feels more correct to do the check in both places that use a repoConfig. [0] osbuild#284 (comment)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
This is a regression test for an issue found during the review of PR#284 [0]. The issue was that ``` ModuleHotfixes *bool `json:"module_hotfixes"` ``` lacked the required `omitempty` which may cause issues with dnfjson. As a quick and easy way to prevent this in the future this commit adds a small test that ensures that we notice any missing `omitempty`. Note that the `rpmmd` part is not strictly needed but it feels more correct to do the check in both places that use a repoConfig. [0] #284 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds module_hotfixes flag to all repo types so it can be used during osbuild. This enables users to disable modularity filtering on specific repositories.
relates to: osbuild/osbuild-composer#3821