Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip PR prefix from PR number in build cache #280

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

achilleas-k
Copy link
Member

We've been saving the PR number to the build cache metadata by reading the branch name in GitLab CI, but the branch name is prefixed with PR-. Save it as a plain number so we can use it for links etc.

Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@achilleas-k achilleas-k added this pull request to the merge queue Nov 28, 2023
Merged via the queue into osbuild:main with commit d9a7f01 Nov 28, 2023
7 checks passed
@achilleas-k achilleas-k deleted the ci-metadata-pr-number branch December 14, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants