Changes to require pinned osbuild commit for the CI runners (HMS-5248) #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the script to not only update osbuild dependency commit for all distros defined in the Schutzfile, but also define it for any distros that didn't have it. This will ensure consistency of using a well known osbuild version when testing image builds in CI and storing it in the S3 CI cache with the osbuild ref being part of the object prefix. Signed-off-by: Tomáš Hozza <[email protected]>
Modify the script to fail in case the host distro version does not have the osbuild dependency commit ID defined in the Schutzfile. This will ensure that we'll always use a well-known osbuild version for testing image builds and for the artifacts stored in the S3 cache. Signed-off-by: Tomáš Hozza <[email protected]>
schutzbot
changed the title
|
I didn't realize that the GH actions also use |
Make sure that the osbuild dependency commit is defined for all distros on which we setup the osbuild repository. Specifically whose that we run in GH actions and in GitLab CI. Signed-off-by: Tomáš Hozza <[email protected]>
We no longer run F40 in GitLab CI, so there's not need to define repo overrides for it. We do not override system repositories for GH actions. Signed-off-by: Tomáš Hozza <[email protected]>
I noticed that the action that is running unit tests on Fedora was setting up YUM repository for osbuild on the Ubuntu runner and then again inside the Fedora container in which it runs unit tests. Setting the osbuild YUM repository on the Ubuntu runner is useless, therefore delete the task. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
force-pushed
the
ensure-osbuild-dependency
branch
from
41e9b76 to
b7485d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we always use well-known osbuild version on CI workers by:
update-schutzfile-osbuildscript unconditionally defining the latest osbuild commit for all distros in theSchutzfile.setup-osbuild-reposcript failing in case the host distro does not have the osbuild dependency commit defined.Define the osbuild dependency commit for every distro we run in GH actions or in GitLab CI. Delete repo overrides for F40, since we no longer run F40 workers in GitLab.
/jira-epic COMPOSER-2318
JIRA: HMS-5248