Add erofs support #1117
Add erofs support #1117
Conversation
|
Currently works to build an erofs |
bcl
force-pushed
the
main-rootfs-erofs
branch
from
2544bd2 to
0c05cbb
Compare
thozza
force-pushed
the
main-rootfs-erofs
branch
from
0c05cbb to
c201271
Compare
|
Rebased due to image build cache layout change (#1130) |
Supports passing the compression type, extended erofs options, and maximum compress physical cluster size.
In preparation for adding erofs support rename the variable since it will be used for more than squashfs.
This will make it easier to select other rootfs types without depending on side-effects like rootfsPipeline being nil.
Add support for erofs by setting the RootfsType on AnacondaInstallerISOTree to ErofsRootfs to select a plain erofs compressed root filesystem for the Anaconda ISO. The mkfs.erofs arguments will look like this: zstd,8 -E all-fragments,dedupe -C 131072
Add tests to make sure the squashfs or erofs (without squashfs) stages are present in the manifest when the RootfsType is set.
bcl
force-pushed
the
main-rootfs-erofs
branch
from
c201271 to
9cc0d18
Compare
|
RHEL10 will be a followup commit, added tests as suggested by @mvo5 |
There was a problem hiding this comment.
Very nice. I would only wonder if we want to make RootfsCompression also some kinda-enum; or if we want to move them together into a single property just called rootfs that contains both the rootfstype and the rootfscompression, just so we can (more easily) validate them together in case some compressions do not fit some rootfstypes?
I pondered that, but chose to leave it free-form for now. It's used by different compression stages so I don't think it makes sense to make it an enum when the allowed values are really up to the osbuild stage. |
Things that are needed:
RHEL 10 kernel needs to support erofs and zstd compression