Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osbuild-ci: install grub2-pc-modules #88

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

thozza
Copy link
Member

@thozza thozza commented Jan 20, 2025

It turned out, that installing grub2-tools is not enough to make 'org.osbuild.grub2.inst' tests run in osbuild. Until now, the test would be skipped, because the osbuild-ci image was never updated in the osbuild repository.

See https://github.com/osbuild/osbuild/actions/runs/12834514251/job/35791994053#step:3:274

...
stages/test/test_grub2_inst.py::test_grub2_partition SKIPPED (cannot...) [ 18%]
stages/test/test_grub2_inst.py::test_grub2_iso9660 SKIPPED (cannot f...) [ 18%]
...

And failures after updating the osbuild-ci image https://github.com/osbuild/osbuild/actions/runs/12812586711/job/35724614320?pr=1981#step:3:1244

...
/usr/lib64/python3.6/subprocess.py:438: CalledProcessError
----------------------------- Captured stdout call -----------------------------
grub2-mkimage (GRUB) 2.12
prefix: (,gpt1)/boot/
----------------------------- Captured stderr call -----------------------------
grub2-mkimage: error: cannot open `/usr/lib/grub/i386-pc/moddep.lst': No such file or directory.
______________________________ test_grub2_iso9660 ______________________________
...

It turned out, that installing grub2-tools is not enough to make
'org.osbuild.grub2.inst' tests run in osbuild. Until now, the test would
be skipped, because the `osbuild-ci` image was never updated in the
osbuild repository.

Signed-off-by: Tomáš Hozza <[email protected]>
@achilleas-k achilleas-k merged commit 72fcea3 into osbuild:main Jan 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants