-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time analysis notebook and dataframe #210
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
notebooks/demo2/time-anlysis.ipynb
Outdated
@@ -0,0 +1,1187 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notebooks/demo2/time-anlysis.ipynb
Outdated
@@ -0,0 +1,1187 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
notebooks/demo2/time-anlysis.ipynb
Outdated
@@ -0,0 +1,1187 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
notebooks/demo2/time-anlysis.ipynb
Outdated
@@ -0,0 +1,1187 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
70% of the pdfs will take a few secs to 24 mins
will this be less than 16 mins or less? since 75% of pdfs take less than 17.4 mins?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is according the standard deviation; avg +- std (0-24min) covers ~70% of the normal distribution. There's the assumption though, that the times are in normal distribution. But yeah the more exact statement would be if take 70th or 75th percentile.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added the updates here: #217 |
This PR adds benchmark run data and analysis notebook.