Prevent ambiguous PRJDIR ending up in vars.json #5408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed that the variable PRJDIR ends up with inconsistent values in vars.json files which is then rendered as a diff from the openQA investigation tab even though likely the effective value used within openQA never differed. The variable PRJDIR is actually never used itself so to prevent confusion we can simply remove all according references. The internal function "prjdir()" is untouched. This change effectively prevents pre-2020 versions of os-autoinst, in particular before commit 9eb2f564 removing the last use of PRJDIR, to work which should not be our concern because for multiple reasons it would be a bad idea if not outright impossible to have a current openQA working with such old versions of os-autoinst. Related progress issue: https://progress.opensuse.org/issues/152392
|
No CI checks failed so we can just assume that this will be fine. Undrafted. |
perlpunk
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed that the variable PRJDIR ends up with inconsistent values in
vars.json files which is then rendered as a diff from the openQA
investigation tab even though likely the effective value used within
openQA never differed. The variable PRJDIR is actually never used itself
so to prevent confusion we can simply remove all according references.
The internal function "prjdir()" is untouched.
This change effectively prevents pre-2020 versions of os-autoinst, in
particular before commit 9eb2f564 removing the last use of PRJDIR, to
work which should not be our concern because for multiple reasons it
would be a bad idea if not outright impossible to have a current openQA
working with such old versions of os-autoinst.
Related progress issue: https://progress.opensuse.org/issues/152392