review comments.

orkes-io · Nov 29, 2023 · 1a17091 · 1a17091
1 parent 68c8105
commit 1a17091
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 17 deletions.
diff --git a/common/src/main/java/com/netflix/conductor/common/run/Workflow.java b/common/src/main/java/com/netflix/conductor/common/run/Workflow.java
@@ -18,7 +18,6 @@
 import javax.validation.constraints.Max;
 import javax.validation.constraints.Min;
 
-import com.netflix.conductor.common.metadata.workflow.IdempotencyStrategy;
 import org.apache.commons.lang3.StringUtils;
 
 import com.netflix.conductor.annotations.protogen.ProtoEnum;
@@ -127,12 +126,8 @@ public boolean isSuccessful() {
     @ProtoField(id = 25)
     private List<Workflow> history = new LinkedList<>();
 
-    @ProtoField(id = 26)
     private String idempotencyKey;
 
-    @ProtoField(id = 27)
-    private String idempotencyStrategy;
-
     public String getIdempotencyKey() {
         return idempotencyKey;
     }
@@ -141,14 +136,6 @@ public void setIdempotencyKey(String idempotencyKey) {
         this.idempotencyKey = idempotencyKey;
     }
 
-    public String getIdempotencyStrategy() {
-        return idempotencyStrategy;
-    }
-
-    public void setIdempotencyStrategy(String idempotencyStrategy) {
-        this.idempotencyStrategy = idempotencyStrategy;
-    }
-
     public List<Workflow> getHistory() {
         return history;
     }

diff --git a/grpc/src/main/java/com/netflix/conductor/grpc/AbstractProtoMapper.java b/grpc/src/main/java/com/netflix/conductor/grpc/AbstractProtoMapper.java
@@ -1082,9 +1082,6 @@ public WorkflowPb.Workflow toProto(Workflow from) {
         for (Workflow elem : from.getHistory()) {
             to.addHistory( toProto(elem) );
         }
-        if (from.getIdempotencyKey() != null) {
-            to.setIdempotencyKey( from.getIdempotencyKey() );
-        }
         return to.build();
     }
 
@@ -1125,7 +1122,6 @@ public Workflow fromProto(WorkflowPb.Workflow from) {
         to.setVariables(variablesMap);
         to.setLastRetriedTime( from.getLastRetriedTime() );
         to.setHistory( from.getHistoryList().stream().map(this::fromProto).collect(Collectors.toCollection(ArrayList::new)) );
-        to.setIdempotencyKey( from.getIdempotencyKey() );
         return to;
     }