Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API Vector::insert and Vector::remove #96

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add new API Vector::insert and Vector::remove #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
30710e9
implementation Vector::insert and Vector::remove
White-Green Aug 30, 2024
4cc0fb0
add tests for Vector::{insert, remove}
White-Green Sep 1, 2024
d0033d6
add benchmarks for Vector::{insert, remove}
White-Green Sep 1, 2024
529dc6a
add specialized push_back implementation
White-Green Sep 1, 2024
023ce91
refactor of Vector implementation
White-Green Sep 1, 2024
76274c0
fix compilation error without default-features
White-Green Sep 1, 2024
5d99c47
mark #[must_use] to insert/remove
White-Green Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions benches/rpds_vector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,88 @@ fn rpds_vector_drop_last_mut(c: &mut Criterion) {
});
}

fn rpds_vector_insert(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector insert", move |b| {
b.iter(|| {
let mut vector: Vector<usize> = Vector::new();

for i in 0..limit {
vector = vector.insert(vector.len() - i, i).unwrap();
}

vector
});
});
}

fn rpds_vector_insert_mut(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector insert mut", move |b| {
b.iter(|| {
let mut vector: Vector<usize> = Vector::new();

for i in 0..limit {
vector.insert_mut(vector.len() - i, i);
}

vector
});
});
}

fn rpds_vector_remove(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector remove", move |b| {
b.iter_with_setup(
|| {
let mut vector: Vector<usize> = Vector::new();

for i in 0..limit {
vector.push_back_mut(i);
}

vector
},
|mut vector| {
for i in (0..limit).rev() {
vector = vector.remove(vector.len() - i - 1).unwrap();
}

vector
},
);
});
}

fn rpds_vector_remove_mut(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector remove mut", move |b| {
b.iter_with_setup(
|| {
let mut vector: Vector<usize> = Vector::new();

for i in 0..limit {
vector.push_back_mut(i);
}

vector
},
|mut vector| {
for i in (0..limit).rev() {
vector.remove_mut(vector.len() - i - 1);
}

vector
},
);
});
}

fn rpds_vector_get(c: &mut Criterion) {
let limit = 100_000;
let mut vector: Vector<usize> = Vector::new();
Expand Down Expand Up @@ -132,6 +214,10 @@ criterion_group!(
rpds_vector_push_back_mut,
rpds_vector_drop_last,
rpds_vector_drop_last_mut,
rpds_vector_insert,
rpds_vector_insert_mut,
rpds_vector_remove,
rpds_vector_remove_mut,
rpds_vector_get,
rpds_vector_iterate
);
Expand Down
86 changes: 86 additions & 0 deletions benches/rpds_vector_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,88 @@ fn rpds_vector_syncdrop_last_mut(c: &mut Criterion) {
});
}

fn rpds_vector_syncinsert(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector sync insert", move |b| {
b.iter(|| {
let mut vector: VectorSync<usize> = VectorSync::new_sync();

for i in 0..limit {
vector = vector.insert(vector.len() - i, i).unwrap();
}

vector
});
});
}

fn rpds_vector_syncinsert_mut(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector sync insert mut", move |b| {
b.iter(|| {
let mut vector: VectorSync<usize> = VectorSync::new_sync();

for i in 0..limit {
vector.insert_mut(vector.len() - i, i);
}

vector
});
});
}

fn rpds_vector_syncremove(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector sync remove", move |b| {
b.iter_with_setup(
|| {
let mut vector: VectorSync<usize> = VectorSync::new_sync();

for i in 0..limit {
vector.push_back_mut(i);
}

vector
},
|mut vector| {
for i in (0..limit).rev() {
vector = vector.remove(vector.len() - i - 1).unwrap();
}

vector
},
);
});
}

fn rpds_vector_syncremove_mut(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("rpds vector sync remove mut", move |b| {
b.iter_with_setup(
|| {
let mut vector: VectorSync<usize> = VectorSync::new_sync();

for i in 0..limit {
vector.push_back_mut(i);
}

vector
},
|mut vector| {
for i in (0..limit).rev() {
vector.remove_mut(vector.len() - i - 1);
}

vector
},
);
});
}

fn rpds_vector_syncget(c: &mut Criterion) {
let limit = 1_000_000;
let mut vector: VectorSync<usize> = VectorSync::new_sync();
Expand Down Expand Up @@ -132,6 +214,10 @@ criterion_group!(
rpds_vector_syncpush_back_mut,
rpds_vector_syncdrop_last,
rpds_vector_syncdrop_last_mut,
rpds_vector_syncinsert,
rpds_vector_syncinsert_mut,
rpds_vector_syncremove,
rpds_vector_syncremove_mut,
rpds_vector_syncget,
rpds_vector_synciterate
);
Expand Down
52 changes: 51 additions & 1 deletion benches/std_vec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,47 @@ fn std_vec_reverse(c: &mut Criterion) {
});
}

fn std_vec_insert(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("std vec insert", move |b| {
b.iter(|| {
let mut vector: Vec<usize> = Vec::new();

for i in 0..limit {
vector.insert(vector.len() - i, i);
}

vector
});
});
}

fn std_vec_remove(c: &mut Criterion) {
let limit = 1 << 12;

c.bench_function("std vec remove", move |b| {
b.iter_with_setup(
|| {
let mut vector: Vec<usize> = Vec::new();

for i in 0..limit {
vector.push(i);
}

vector
},
|mut vector| {
for i in (0..limit).rev() {
vector.remove(vector.len() - i - 1);
}

vector
},
);
});
}

fn std_vec_get(c: &mut Criterion) {
let limit = 100_000;
let mut vector: Vec<usize> = Vec::new();
Expand Down Expand Up @@ -108,5 +149,14 @@ fn std_vec_iterate(c: &mut Criterion) {
});
}

criterion_group!(benches, std_vec_push, std_vec_pop, std_vec_reverse, std_vec_get, std_vec_iterate);
criterion_group!(
benches,
std_vec_push,
std_vec_pop,
std_vec_reverse,
std_vec_insert,
std_vec_remove,
std_vec_get,
std_vec_iterate
);
criterion_main!(benches);
Loading